Fix GH-12143: Remove pre round #12260
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improved version of #12162.
This PR fixes #12143
Simply removing the pre round caused the following problems.
Therefore, first, adjust the digits so that the 15th digit, which is guaranteed to be accurate, is an integer.
For example,
0.285(0.28499999999999998)
to285000000000000
.Then, adjust again to the digit that should be calculated to use the helper.
For example,
285000000000000
to28.5
Floating point numbers have some degree of error, so it try to approximate the value as close to an integer as possible.
Therefore, by setting the range that guarantees accuracy to an integer, we can approximate it in a way that is closer to our intuition.
this change
simply removed pre-round