-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Adds DateTime[Immutable]::createFromTimestamp #12413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
29eca46
Added DateTime[Immutable]::createFromTimestamp / date_create_[immutab…
marc-mabe 9df735e
fixup
marc-mabe c7cc823
DateRangeError + static return type
marc-mabe 178f7ce
Tests should pass 32bit now
marc-mabe 759a9e4
Removed fn date_create_[immutable_]from_timestamp as suggested by @de…
marc-mabe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,6 +159,12 @@ function date_create_from_format( | |
function date_create_immutable_from_format( | ||
string $format, string $datetime, ?DateTimeZone $timezone = null): DateTimeImmutable|false {} | ||
|
||
/** @refcount 1 */ | ||
function date_create_from_timestamp(int|float $timestamp): DateTime {} | ||
|
||
/** @refcount 1 */ | ||
function date_create_immutable_from_timestamp(int|float $timestamp): DateTimeImmutable {} | ||
|
||
/** | ||
* @return array<string, mixed> | ||
* @refcount 1 | ||
|
@@ -362,6 +368,12 @@ public static function createFromInterface(DateTimeInterface $object): DateTime | |
*/ | ||
public static function createFromFormat(string $format, string $datetime, ?DateTimeZone $timezone = null): DateTime|false {} | ||
|
||
/** | ||
* @tentative-return-type | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
* @alias date_create_from_timestamp | ||
*/ | ||
public static function createFromTimestamp(int|float $timestamp): static {} | ||
|
||
/** | ||
* @return array<string, int|array>|false | ||
* @tentative-return-type | ||
|
@@ -466,6 +478,12 @@ public static function __set_state(array $array): DateTimeImmutable {} | |
*/ | ||
public static function createFromFormat(string $format, string $datetime, ?DateTimeZone $timezone = null): DateTimeImmutable|false {} | ||
|
||
/** | ||
* @tentative-return-type | ||
* @alias date_create_immutable_from_timestamp | ||
*/ | ||
public static function createFromTimestamp(int|float $timestamp): static {} | ||
|
||
/** | ||
* @return array<string, int|array>|false | ||
* @tentative-return-type | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.