ext/mysqli: mysql_thread_id/mysqli_kill internal changes proposal. #12473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
mysqli_threadid_kill_upd
branch
3 times, most recently
from
563e738 to
d12f173
Compare
- Both mysql_thread_id and mysql_kill despite dealing possibly with 64 bits values operates in reality with 32 bits internally, leading to truncation. They are both deprecated and passing commands instead is advised.
devnexen
force-pushed
the
mysqli_threadid_kill_upd
branch
2 times, most recently
from
99b4641 to
78e15ac
Compare
devnexen
force-pushed
the
mysqli_threadid_kill_upd
branch
from
78e15ac to
bac062b
Compare
devnexen
force-pushed
the
mysqli_threadid_kill_upd
branch
9 times, most recently
from
cdfac89 to
5e2f76a
Compare
devnexen
force-pushed
the
mysqli_threadid_kill_upd
branch
from
5e2f76a to
484923c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are both deprecated and passing commands instead is advised.