JIT/AArch64: Fix an undefined symbol issue #12687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AArch64 function `zend_jit_set_veneer()`, some debug code calls two other functions `ir_disasm_find_symbol()` and `ir_disasm_add_symbol()` defined in `ir_disasm.c`. However, `ir_disasm.c` is compiled under the condition that capstone is available. This causes an undefined symbol issue while loading `opcache.so` when JIT is triggered if PHP is built without `--with-capstone`. We find this issue on MacOS 12.5 if we build PHP with Clang 14. It does not appear immediately when using other versions of toolchains because of lazy binding. To reproduce this with Linux/GCC, we can disable lazy binding by `export LD_BIND_NOW=1` before building PHP. This fixes the issue by making the debug code conditionally compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AArch64 function
zend_jit_set_veneer(), some debug code calls two other functionsir_disasm_find_symbol()andir_disasm_add_symbol()defined inir_disasm.c. However,ir_disasm.cis compiled under the condition that capstone is available. This causes an undefined symbol issue while loadingopcache.sowhen JIT is triggered if PHP is built without--with-capstone.We find this issue on MacOS 12.5 if we build PHP with Clang 14. It does not appear immediately when using other versions of toolchains because of lazy binding. To reproduce this with Linux/GCC, we can disable lazy binding by
export LD_BIND_NOW=1before building PHP.This fixes the issue by making the debug code conditionally compile.