Skip to content

Sync YFLAGS in scripts/dev/genfiles with PHP_PROG_BISON macro defaults #12709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

petk
Copy link
Member

@petk petk commented Nov 17, 2023

  • Adds -Wall YFLAGS when using the scripts/dev/genfiles to have similar output there in case things need to be fixed.
  • Syncs @ suppression operators across the bison calls.

The scripts/dev/genfiles script is used when releasing the PHP. Flags can be to some extent synced with the M4 macro here.

- Adds -Wall YFLAGS when using the scripts/dev/genfiles to have similar
  output there in case things need to be fixed.
- Syncs @ suppression operators across the bison calls.
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk petk merged commit d7d3a1c into php:master Nov 22, 2023
@petk petk deleted the patch-bison-flags branch November 22, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants