Add miliseconds do the test time output #12729
Conversation
jorgsowa
changed the title
|
This doesn't seem to work properly: |
jorgsowa
force-pushed
the
add-miliseconds-to-test-output
branch
from
65d36d4 to
25c8ac4
Compare
jorgsowa
force-pushed
the
add-miliseconds-to-test-output
branch
from
816bad9 to
ae56a49
Compare
|
This breaks on 32-bit. https://github.com/php/php-src/actions/runs/7367562603/job/20050980094 |
|
TBH this change seems questionable. What are we actually measuring here? For short tests, the actual test execution time will be dwarfed by the creation of potentially multiple processes (skipif, test, cleanup) and PHP startup. For longer tests, milliseconds aren't meaningful. |
|
Sorry for breaking. I have pushed the fix for this issue: #13064 The reason for the change was that we run short tests we get the output If you think this doesn't bring any value I'm fine with reverting changes by myself or anyone else. |
There was a problem hiding this comment.
If confusion is an actual problem, a simple fix might've been making the script say "<1 seconds".
Note that a completely empty test (<?php ?>) still takes 0.024 seconds on my machine. As such, milliseconds don't seem useful. Anyway, I don't care too much because that number is mostly irrelevant to me. It's just obviously important that 32-bit continues working.
| { | ||
| echo "=====================================================================\nTIME END " . date('Y-m-d H:i:s', $end_time) . "\n"; | ||
| echo "=====================================================================\nTIME END " . date('Y-m-d H:i:s', $start_timestamp + (int)(($end_time - $start_time)/1e9)) . "\n"; |
There was a problem hiding this comment.
This does not look correct. $start_timestamp is rounded down. The end time can still be $start_timestamp + 1, even if ($end_time - $start_time) < 1. I don't understand why this was changed at all.
This PR adds the fractional part (3 digits) of the time taken by tests to the test output.