Skip to content

Remove unused build variables #12746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

petk
Copy link
Member

@petk petk commented Nov 21, 2023

  • LFLAGS
  • PHP_LIBS
  • SHARED_LIBTOOL
  • EXT_LIBS

These were part of the build system in the past and are no longer used in current code.

- LFLAGS
- PHP_LIBS
- SHARED_LIBTOOL
- EXT_LIBS

These were part of the build system in the past and are no longer used
in current code.
@iluuu1994
Copy link
Member

@petk Do you have merge access? If not it would make sense to request it.

@petk
Copy link
Member Author

petk commented Nov 22, 2023

Yes, I have the merge access. I'll merge this one then :) Thanks.
It's just a habit of opening PRs so there's a bit of an overview of what's being done :D

@iluuu1994
Copy link
Member

@petk Ah, good 🙂 I just asked because a lot of PRs go unreviewed, and it would be unfortunate if they went stale. Thanks for your work!

@petk petk merged commit 5140889 into php:master Nov 22, 2023
@petk petk deleted the patch-remove-unused-variables branch November 22, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants