Fix crashes with entity references and predefined entities #13004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopening. This doesn't work on libxml2 < 2.12.0 because the |
Girgias
approved these changes
Jan 16, 2024
| case XML_ENTITY_REF_NODE: | ||
| /* Entity reference nodes are special: their children point to entity declarations, | ||
| * but they don't own the declarations and therefore shouldn't free the children. | ||
| * Moreover, there can be N>1 reference nodes for a single entity declarations. */ |
There was a problem hiding this comment.
The N>1 could potentially cause confusing here? Not sure what better wording is possible tho.
There was a problem hiding this comment.
Fix:
Suggested change
| * Moreover, there can be N>1 reference nodes for a single entity declarations. */ | |
| * Moreover, there can be more than one reference node for a single entity declarations. */ |
There was a problem hiding this comment.
The suggestion looks good, thank you!
Comment on lines
+211
to
+213
| #if LIBXML_VERSION >= 21200 | ||
| xmlFreeEntity(entity); | ||
| #else |
There was a problem hiding this comment.
I suppose it is unlikely that the extension is compiled against the newer version and an older libxml version is used at runtime.
There was a problem hiding this comment.
Should be not done, that's generally always a bad idea for libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two issues here:
The fix for the last issue is fairly easy to do on 8.3, but may require a slightly different approach on 8.2. Therefore, for now this is 8.3-only.