Skip to content

Fix breaking intl test #13008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kocsismate
Copy link
Member

Hopefully, fixes the new test failure.

@iluuu1994
Copy link
Member

There's already a PR by @devnexen #13001

I think if a problem cannot be fixed in a few hours it's generally better to revert. This avoids accidental branching with fixes needing to be cherry-picked manually, and multiple people looking into the issue.

@devnexen
Copy link
Member

There's already a PR by @devnexen #13001

I think if a problem cannot be fixed in a few hours it's generally better to revert. This avoids accidental branching with fixes needing to be cherry-picked manually, and multiple people looking into the issue.

true, going to do it now.

@kocsismate
Copy link
Member Author

kocsismate commented Dec 23, 2023

Ah, ok. My initial thought was that the issue is caused by e.g. an occasional intl lib upgrade where the "xx" code became acccepted.

@kocsismate kocsismate closed this Dec 23, 2023
@kocsismate kocsismate deleted the fix-intl-test branch December 23, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants