Remove unused includes of php_random.h #13131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change php_random.h was listed in 146 different *.dep files for a
env CC=clang ./configure --without-sqlite3 --without-pdo-sqlite
build, after this change it's only listed in 110 of them, preventing uselessly
recompiling those files when working on ext/random, mostly caused by the include
in ext/standard/basic_functions.h.
nielsdos
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
LCTM, nice find.
One thing I'm not sure about is if third party extensions may include basic_functions.h and therefore implicitly assume php_random.h is included. In that case an UPGRADING.INTERNALS note may be necessary, but I'm not sure if this is the case.
Using a feature and not including the header is a bug. I understand that after a certain time observable behavior becomes a feature, but in this case I believe the fix to be sufficiently simple and the failure mode sufficiently obvious to not add a note to UPGRADING.INTERNALS, because too many notes can also distract from the important stuff. |
|
That's fair |
bukka
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change php_random.h was listed in 146 different *.dep files for a
build, after this change it's only listed in 110 of them, preventing uselessly recompiling those files when working on ext/random, mostly caused by the include in ext/standard/basic_functions.h.