Skip to content

Improve ASSIGN_OBJ RC inference #13237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve ASSIGN_OBJ RC inference #13237

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Jan 24, 2024 •
edited
Loading

ASSIGN_OBJ may only modify RC if it implements __set.

@iluuu1994 iluuu1994 requested a review from dstogov as a code owner January 24, 2024 15:01
@iluuu1994 iluuu1994 force-pushed the improved-assign-obj-rc-inference branch from 4337cc5 to ad68cb9 Compare January 24, 2024 15:05
@iluuu1994 iluuu1994 mentioned this pull request Jan 24, 2024
Closed
dstogov
dstogov requested changes Jan 29, 2024
View reviewed changes
@iluuu1994 iluuu1994 force-pushed the improved-assign-obj-rc-inference branch 2 times, most recently from c68c3ce to f903c03 Compare January 29, 2024 11:05
dstogov
dstogov reviewed Jan 29, 2024
View reviewed changes
@iluuu1994
Improve ASSIGN_OBJ RC inference
75b8d40 
ASSIGN_OBJ may only modify RC if it implements __set.
@iluuu1994 iluuu1994 force-pushed the improved-assign-obj-rc-inference branch from f903c03 to 75b8d40 Compare January 30, 2024 15:37
@iluuu1994 iluuu1994 changed the title Improve ASSIGN_OBJ[_REF] RC inference Improve ASSIGN_OBJ RC inference Jan 30, 2024
@iluuu1994
Copy link
Member Author

I dropped the ASSIGN_OBJ_REF changes because they would require the same check. However, ASSIGN_OBJ is much more relevant, the ref variant is probably negligible.

@iluuu1994 iluuu1994 closed this in 668edf2 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov requested changes

Assignees
No one assigned
Labels
Category: Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @dstogov