ZEND_ELEMENT_COUNT usage reduction.

[devnexen]

clang 18 is going to be released and in the meantime the counted_by attribute usage had been constrained to true flexible arrays, typical cases such as type name[1] ZEND_ELEMENT_COUNT(size) no longer build.

[iluuu1994]

Was nice while it lasted 😄 Thanks!

[iluuu1994]

I suppose we could try to make two distinct macros for GCC and Clang (i.e. one that works with true flexible arrays, and one that works with the [1] variant) but it's probably not worth it. It would be interesting to see whether there's a difference in the generated assembly in the first place. I've been using these commands:

llvm-objdump --disassemble --no-addresses --no-show-raw-insn --demangle --symbolize-operands $(which php-dev) > before.txt
# Recompile
llvm-objdump --disassemble --no-addresses --no-show-raw-insn --demangle --symbolize-operands $(which php-dev) > after.txt
git diff --no-index before.txt after.txt

[devnexen]

Was nice while it lasted 😄 Thanks!

There is still few usage left :-). Anyhow, I ve seen the feature being reverted once in llvm repo, might have cause subtle issues in the first place.

[bukka]

It might be worth to consider introducing some limited headers usable for C++ (making some structs opaque for C++) There are not probably that many C++ extensions and they could deal with that by having its own wrapper if they need something more complex.

[bukka]

Just for those that don't know that (which I was part of until recently), C++ is the reason why we don't use true flexible headers...