Fix typedef redefinition warnings #13347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP at this point still requires only C99, so this fixes warnings "redefinition of typedef '...' is a C11 feature [-Wtypedef-redefinition]" when building with Clang and -Wtypedef-redefinition.
|
To not cause confusion here, I'll close this one because it only makes cognitive load in the PR queue... |
|
@petk Have you decided not to merge this? |
|
It's like fixing something for only C99 and in C11 it will be ok :D |
|
I'll leave it up to you 😊 As long as we're officially supporting C99, it makes sense to avoid warnings there (although it's unlikely someone will actually run into an issue here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a question, since PHP at this point still requires only C99 and this PR fixes warnings "redefinition of typedef '...' is a C11 feature [-Wtypedef-redefinition]" when building with Clang and -Wtypedef-redefinition.
This sounds good for now or should we bump to C11 at some point in the near future?
The issue can be noticed like this: