Remove remainings of recent oci extensions removal #13352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Feb 7, 2024
| @@ -123,7 +123,7 @@ rem work-around for some spawned PHP processes requiring OpenSSL | |||
| echo extension=php_openssl.dll >> %PHP_BUILD_DIR%\php.ini | |||
|
|
|||
| rem remove ext dlls for which tests are not supported | |||
| for %%i in (ldap oci8_12c pdo_oci) do ( | |||
| for %%i in (ldap) do ( | |||
There was a problem hiding this comment.
it would be nice to test LDAP ext on windows too
There was a problem hiding this comment.
Feel free to fix the underlying issue and PR that!
devnexen
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.