Skip to content

Remove unused symbol HAVE_BSD_ICONV #13373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2024
Merged

Remove unused symbol HAVE_BSD_ICONV #13373

merged 1 commit into from
Feb 11, 2024

Conversation

petk
Copy link
Member

@petk petk commented Feb 11, 2024

No description provided.

nielsdos
nielsdos approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and from a quick search via GitHub's code search it doesn't look like this is used in PECL or anything.

devnexen
devnexen approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Like it s done in cirrus's ci, the 3rd party package version is used rather than the system's version.

@petk petk merged commit 250547c into php:master Feb 11, 2024
@petk petk deleted the patch-remove-have-bsd-iconv branch February 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: iconv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petk @devnexen @nielsdos