Zend fiber support for sparc64 (OpenBSD) #13382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You know already the existence of boostorg/context, ideally the jump_fcontext/make_fcontext parts would need to be upstreamed. |
Already done, see boostorg/context#251 |
This was tested on OpenBSD sparc64 and all fiber related tests pass. On OpenBSD stackghost prevents the modification of the return address and therefor an extra trampoline is needed in make_fcontext(). This should not matter on other OS implementing sysv ABI and the trampoline should work there as well.
cjeker
force-pushed
the
openbsd_sparc64
branch
from
654ef6a to
70bada7
Compare
trowski
approved these changes
Feb 26, 2024
|
Upstream merged the code. |
devnexen
approved these changes
Mar 12, 2024
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the necessary asm functions for sparc64 to support Zend fibers.
This implements jump_fcontext() and make_fcontext() for sparc64_sysv_elf and allows to run modern php on OpenBSD/sparc64.
All fiber related test pass on my OpenBSD sparc64 machine.