Skip to content

Test Round: Added tests to check operation with existing implementation #13399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SakiTakamachi
Copy link
Member

Related #12222

@Girgias
Copy link
Member

Girgias commented Feb 17, 2024

I didn't mean to say to create a new PR to add the tests, but just to split your existing PR into two commits :)

But this is fine too :)

@Girgias Girgias merged commit ed1c9d8 into php:master Feb 17, 2024
@SakiTakamachi
Copy link
Member Author

I see, I misunderstood. Thank you!

@SakiTakamachi SakiTakamachi deleted the feature/expand-rounding-target-test branch February 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants