ext/intl: IntlDateFormatter class removing redundant error message info. #13465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correcting new IntlChar class constants typos.
Girgias
approved these changes
Feb 21, 2024
Comment on lines
181
to
185
| } else { | ||
| intl_error_set(NULL, U_ILLEGAL_ARGUMENT_ERROR, | ||
| "intltz_create_enumeration: invalid argument type", 0); | ||
| "invalid argument type", 0); | ||
| RETURN_FALSE; | ||
| } |
There was a problem hiding this comment.
This feels like it should be a TypeError, something to remember as future improvements
There was a problem hiding this comment.
Actually this looks like it should just use Fast ZPP with a int|string type check.
Comment on lines
85
to
90
| if (!tzobj->initialized) { | ||
| intl_error_set(NULL, U_ILLEGAL_ARGUMENT_ERROR, | ||
| "intltz_from_date_time_zone: DateTimeZone object is unconstructed", | ||
| "DateTimeZone object is unconstructed", | ||
| 0); | ||
| RETURN_NULL(); | ||
| } |
There was a problem hiding this comment.
Note, this should probably an Error as uninitialized objects means something BAD happened.
Comment on lines
61
to
65
| /** @cvalue UCHAR_ID_COMPAT_MATH_START */ | ||
| public const int PROPERTY_ID_COMPT_MATH_START = UNKNOWN; | ||
| public const int PROPERTY_ID_COMPAT_MATH_START = UNKNOWN; | ||
| /** @cvalue UCHAR_ID_COMPAT_MATH_CONTINUE */ | ||
| public const int PROPERTY_ID_COMPT_MATH_CONTINUE = UNKNOWN; | ||
| public const int PROPERTY_ID_COMPAT_MATH_CONTINUE = UNKNOWN; | ||
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correcting new IntlChar class constants typos.