Refactor union semun in ext/sysvsem #13473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The union semun is always defined in php-src code. Current systems require user to define it manually as done in the ext/sysvsem/sysvsem.c. The conditional checks for HAVE_SEMUN were unused. The PHP 3.0.12 AIX bug bugs.php.net/2149 was fixed by the removal of __GNU_LIBRARY__ check, so this now further simplifies the code. The Autoconf AC_CHECK_TYPES checks if system by any chance has the union semun, and by default defines the HAVE_UNION_SEMUN.
devnexen
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The union semun is always defined in php-src code. Current systems require user to define it manually as done in the ext/sysvsem/sysvsem.c. The conditional checks for
HAVE_SEMUNwere unused. The PHP 3.0.12 AIX bug bugs.php.net/2149 was fixed by the removal of__GNU_LIBRARY__check, so this now further simplifies the code. The AutoconfAC_CHECK_TYPESchecks if system by any chance has the union semun, and by default defines theHAVE_UNION_SEMUN.