Fix GH-13519: PGSQL_CONNECT_FORCE_RENEW with persistent connections.

[devnexen]

persistent connections did not take in account this flag, after the usual link sanity checks, we remove its entry.

[SakiTakamachi]

May I ask why you check links?

[devnexen]

May I ask why you check links?

Do you mean in general ?

[SakiTakamachi]

after the usual link sanity checks, we remove its entry.

I thought it would be possible to remove it before checking, so I asked.

My understanding of EG is still limited, so I'm sorry if this is a strange question.

[devnexen]

fair enough it s mostly the "RESET ALL" command which I give a chance to operate.

[SakiTakamachi]

Thank you.

If we don't RESET ALL, will the parameters be carried over to new connections?

[devnexen]

ah no it is pretty useless I just recall RESET ALL is for the current connection, will change.

[SakiTakamachi]

I've got it. I'm of the same understanding.

Therefore, it seems possible to remove it at an earlier stage.

[SakiTakamachi]

LGTM

[SakiTakamachi]

@devnexen

The skipif path on master has changed, so you may need to modify that.

[SakiTakamachi]

config too. It should be in the inc directory

[devnexen]

oh I forgot thx

[SakiTakamachi]

There is a segment fault in master.
Maybe zend_hash_del() is the cause?

[devnexen]

I can see however it does not happen on lower branches and on master it happens on non ZTS builds. Not sure which change matters on this topic on master.

[SakiTakamachi]

@nielsdos

Does this seem related to #13381?

[nielsdos]

@nielsdos

Does this seem related to #13381?

I don't believe so. I'll take a look now in detail.