Skip to content

Sync CODEOWNERS #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Sync CODEOWNERS #13623

wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Mar 7, 2024

This adds CODEOWNERS also to PHP-8.2 branch. See #13591

This is a combination of master and PHP-8.3 branches:
ext/imap @Girgias (for PHP-8.2 and PHP-8.3)
ext/pdo_odbc @NattyNarwhal as noted here af80cba#comments

This adds CODEOWNERS also to PHP-8.2 branch.
@petk petk requested review from bukka and iluuu1994 March 7, 2024 21:58
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this file consistent across branches makes sense to me, as GitHub uses the file from the target branch for PRs.

@petk petk closed this in a284c3e Mar 9, 2024
@petk petk deleted the patch-PHP-8.2-CODEOWNERS branch March 9, 2024 00:31
@petk
Copy link
Member Author

petk commented Mar 9, 2024

And it works! Added to PHP-8.2 and up accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants