Skip to content

Fix brew action #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Fix brew action #13659

merged 1 commit into from
Mar 10, 2024

Conversation

shivammathur
Copy link
Member

@shivammathur shivammathur commented Mar 10, 2024

This PR patches brew before installing packages to ensure that it overwrites existing files while linking the dependencies.

Alternatives, I tested

  1. brew install command has a --overwrite flag, but it does not work for recursive dependencies.
  2. Running brew cleanup and installing all dependencies again, that is very slow.

@shivammathur shivammathur requested a review from iluuu1994 March 10, 2024 07:53
@shivammathur shivammathur requested a review from TimWolla as a code owner March 10, 2024 07:53
@shivammathur shivammathur marked this pull request as draft March 10, 2024 08:05
We patch brew to ensure it overwrites files while linking the dependencies
@shivammathur shivammathur marked this pull request as ready for review March 10, 2024 08:29
@shivammathur shivammathur merged commit 0e05f26 into php:PHP-8.2 Mar 10, 2024
shivammathur added a commit that referenced this pull request Mar 10, 2024
* PHP-8.2:
    Fix brew action (#13659)
    We patch brew to ensure it overwrites files while linking the dependencies
shivammathur added a commit that referenced this pull request Mar 10, 2024
* PHP-8.3:
Fix brew action (#13659)
We patch brew to ensure it overwrites files while linking the dependencies
iluuu1994 pushed a commit to iluuu1994/php-src that referenced this pull request Oct 2, 2024
We patch brew to ensure it overwrites files while linking the dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants