Fix ASan build #13757
Closed
Fix ASan build #13757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
requested changes
Mar 19, 2024
There was a problem hiding this comment.
see: actions/runner-images#9491
We can either wait until the end of the week where the fix will be rolled out or sudo sysctl vm.mmap_rnd_bits=28.
iluuu1994
force-pushed
the
fix-asan
branch
2 times, most recently
from
69901f9 to
4d0596e
Compare
|
@TimWolla Good find, thank you! Let's add this line and drop it once the issue is resolved. |
See actions/runner-images#9491 (comment) The mentioned workaround doesn't work for us because we run ASan inside Docker. Instead, we switch to ubuntu-20.04 as the host. The docker setup itself remains the same.
|
@TimWolla Actually, the previous fix was accidentally correct. The mentioned workaround doesn't work for us because we run the ASan build inside Docker, and thus the command runs it in the container rather than the host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See actions/runner-images#9491 (comment)
The mentioned workaround doesn't work for us because we run ASan inside Docker.
Instead, we switch to ubuntu-20.04 as the host. The docker setup itself remains
the same.