ext/posix: adding posix_mkfifoat/posix_mknodat. #13829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
posix_mkfifoat
branch
5 times, most recently
from
b2346e1 to
d0fcce3
Compare
bukka
reviewed
Mar 29, 2024
Comment on lines
+30
to
+42
| bool(false) | ||
| bool(false) | ||
| posix_mknodat(): Argument #4 ($major) cannot be 0 for the POSIX_S_IFCHR and POSIX_S_IFBLK modes | ||
| bool(false) | ||
| bool(false) | ||
| posix_mkfifoat(): Argument #1 ($file_descriptor) must be of type int|resource, stdClass given |
There was a problem hiding this comment.
this is pretty much just a failure test. Can you write some success test with appropriate skips?
kocsismate
reviewed
Apr 9, 2024
ext/posix/posix.c
Outdated
| #ifdef HAVE_MAKEDEV | ||
| php_dev = makedev(major, minor); | ||
| #else | ||
| zend_value_error("Cannot create a block or character device, creating a normal file instead"); |
There was a problem hiding this comment.
This should be a warning if we want to continue the execution
The additional directory file descriptor argument allows to operate from a relative path perspective but those new calls can still work with absolute paths.
devnexen
force-pushed
the
posix_mkfifoat
branch
from
e4cfd18 to
613e8d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional directory file descriptor argument allows to operate from a relative path perspective but those new calls can still work with absolute paths.