ext/zip: add ZipArchive::openBuffer method #14078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soner Sayakci <[email protected]>
shyim
force-pushed
the
add-ziparchive-openbuffer
branch
from
023e619 to
b9495a6
Compare
41 tasks
|
Hi php-team! It's possible to push this new feature into PHP-8.4 ? Thanks for reply! |
kocsismate
reviewed
Jun 21, 2024
kocsismate
reviewed
Sep 28, 2024
| @@ -641,7 +641,6 @@ class ZipArchive implements Countable | |||
| /** @tentative-return-type */ | |||
| public function open(string $filename, int $flags = 0): bool|int {} | |||
|
|
|||
| /** @tentative-return-type */ | |||
There was a problem hiding this comment.
you also have to regenerate the arginfo file when changing the stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow opening read-only zips by string.
An example use-case would be to download a zip file and without saving it to disk, to open it and get one file out of it.
See also #11594
It's my first PR, I run the test with also Valgrind. Did I miss something 🤔?