Use AC_SEARCH_LIBS for socketpair, gethostname and gethostbyaddr #14116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socketpair(): * C library: Solaris 11.4 and most other systems * libsocket: Solaris <= 11.3 and illumos * libnetwork: Haiku The gethostname() check is moved to AC_CHECK_FUNCS: * C library: most systems * libnsl: none * libnetwork: Haiku (which is already checked in the libraries section) The gethostbyaddr(): * C library: most systems, Solaris 11.4 * libnsl: Solaris 11.3, illumos * libnetwork: Haiku This also removes redundant unused symbols: - HAVE_GETHOSTBYADDR - HAVE_LIBNETWORK - HAVE_LIBNSL The outdated comment about -lnsl and -lsocket linking has been removed because these systems are long not supported anymore and this issue is not relevant anymore like mentioned. The initial solution was different than the one with the PHP_CHECK_FUNC macros at the current versions. See commit a188fac where the gethostbyaddr() was checked conditionally based on the gethostname() availability in libc. Main issue was mostly related to the redundant nsl library being always linked because of the AC_CHECK_LIB.
devnexen
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socketpair():
The gethostname() check is moved to AC_CHECK_FUNCS:
The gethostbyaddr():
This also removes redundant unused symbols:
The outdated comment about -lnsl and -lsocket linking has been removed because these systems are long not supported anymore and this issue is not relevant anymore like mentioned. The initial solution was different than the one with the PHP_CHECK_FUNC macros at the current versions. See commit a188fac where the gethostbyaddr() was checked conditionally based on the gethostname() availability in libc. Main issue was mostly related to the redundant nsl library being always linked because of the AC_CHECK_LIB.