Skip to content

Fix incorrect inheritance of private trait methods #14163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024

Conversation

dstogov
Copy link
Member

@dstogov dstogov commented May 7, 2024

The bug was introduced in c6b75f9

@dstogov dstogov requested a review from iluuu1994 as a code owner May 7, 2024 09:40
dstogov referenced this pull request May 7, 2024
* Fix prototype for trait methods

Fixes GH-14009

* Clenup do_inheritance_check_on_method()

Remove wierd checks and define the behavior by explicit set of flags

* Fix naming and indentation

---------

Co-authored-by: Ilija Tovilo <[email protected]>
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstogov dstogov merged commit 7a9e0fb into php:PHP-8.2 May 7, 2024
8 checks passed
dstogov added a commit that referenced this pull request May 7, 2024
* PHP-8.2:
  Fix incorrect inheritance of private trait methods (#14163)
dstogov added a commit that referenced this pull request May 7, 2024
* PHP-8.3:
  Fix incorrect inheritance of private trait methods (#14163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants