ext/pcntl: adding SIGTRAP handling for freebsd. #14266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a restricted file descriptor based syscall by the system had been attempted, a SIGTRAP is raised with the syscall id.
|
This could be just me, as I'm not a freebsd user so I don't know the details, but looking at the source code: It seems that si_sycall and si_trapno will always have the same value because they're overlapping parts of the union? |
|
CI failures are legit |
nielsdos
reviewed
May 22, 2024
| #ifdef SIGTRAP | ||
| case SIGTRAP: | ||
| # if defined(si_syscall) && defined(__FreeBSD__) | ||
| if (siginfo->si_code == TRAP_CAP) { |
There was a problem hiding this comment.
I don't have FreeBSD, and I have no idea what our lowest supported version is, but is this TRAP_CAP constant old enough that it won't cause build failures on older FreeBSD's that we support?
There was a problem hiding this comment.
AFAIK TRAP_CAP appeared before the si_syscall shortcut.
nielsdos
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a restricted file descriptor based syscall by the system had been attempted, a SIGTRAP is raised with the syscall id.