-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix header errors when parsed standalone #14272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything bad.
I'm not sure why do you need a separate header for zend_result...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is annoying for multiple reasons: 1. LSPs can show many errors for these files. 2. LSP can stop parsing these files completely if there are too many errors, resulting in spotty LSP features.
8bd45c3
to
5edc5e5
Compare
It reduced a few imports of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor, but would like to point out this RFC: https://wiki.php.net/rfc/include_cleanup and this PR: #10609.
I believe there should be a more systematic approach than just making a few changes here and there when one notices the issues.
I'm aware of the RFC, but since it was declined, it doesn't seem sincere to make the same changes again. Another proposal might be more successful now, with less drama. |
This PR adds forward declarations which was an idea I proposed in https://wiki.php.net/rfc/include_cleanup but was rejected by the majority of PHP developers, including @dstogov - now I wonder why he agreed with this PR ... ? |
This is annoying for multiple reasons:
On my machine, two debug build without ccache took 55s/56s for
master
, and 56s/56s for this branch, so it does not seem like it changed significantly.