Wrap gdImageCreateFrom* checks in AC_CACHE_CHECK #14443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables cross-compiling edge cases to manually override the checks with the php_cv_lib_gd_gdImageCreateFrom* cache variables.
devnexen
approved these changes
Jun 2, 2024
|
Targeted for 8.3 maybe? :) It will probably take another release cycle but my goal is to get cross compilation working without having to autoreconf. |
|
@orlitzky, sure. I think we can do that, yes. Probably then PHP-8.2 since this change got into PHP-8.2. I'll recheck... |
petk
added a commit
to petk/php-src
that referenced
this pull request
Jul 10, 2024
This enables cross-compiling simplifications when using external GD library as requested in phpGH-14443 using cache variables: * php_cv_lib_gd_gdImageCreateFromPng * php_cv_lib_gd_gdImageCreateFromAvif * php_cv_lib_gd_gdImageCreateFromWebp * php_cv_lib_gd_gdImageCreateFromJpeg * php_cv_lib_gd_gdImageCreateFromXpm * php_cv_lib_gd_gdImageCreateFromBmp * php_cv_lib_gd_gdImageCreateFromTga For example: ./configure --host=... --build=... --enable-gd --with-external-gd \ php_cv_lib_gd_gdImageCreateFromPng=yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables cross-compiling edge cases to manually override the checks with the php_cv_lib_gd_gdImageCreateFrom* cache variables.
I'll double recheck this if everything is written correctly... Creating dynamic cache variables names might be a bit error prone. Otherwise, it seems to work ok.