Remove redundant _WIN32 compile definitions #14458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_WIN32 is defined by all compilers on Windows when targeting 32-bit ARM, 64-bit ARM, x86, or x64. This removes redundant definition in ext/zip and erroneous CFLAG_ENCHANT variable (should be CFLAGS_ENCHANT).
github-actions
bot
added
Category: Build System
Extension: enchant
Extension: zip
labels
|
If everyone's fine, merge coming up here in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_WIN32 is defined by all compilers on Windows when targeting 32-bit ARM, 64-bit ARM, x86, or x64. This removes redundant definition in ext/zip and erroneous CFLAG_ENCHANT variable (should be CFLAGS_ENCHANT).