Remove conditional pg_encoding_to_char usage #14557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Jun 13, 2024
The pg_encoding_to_char is available in PostgreSQL since ~7.3 where also the --enable-multibyte option was removed. PHP minimum PostgreSQL version at this point is 9.1, which also has the pg_encoding_to_char declaration in libpq-fe.h. This removes conditional usage and the HAVE_PGSQL_WITH_MULTIBYTE_SUPPORT symbol.
petk
force-pushed
the
patch-pgsql-pg_encoding_to_char
branch
from
d81f9d8 to
8b9a47d
Compare
devnexen
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pg_encoding_to_char is available in PostgreSQL since ~7.3 where also the --enable-multibyte option was removed. PHP minimum PostgreSQL version at this point is 9.1, which also has the pg_encoding_to_char declaration in libpq-fe.h.
This removes conditional usage and the HAVE_PGSQL_WITH_MULTIBYTE_SUPPORT symbol.