Skip to content

ext/gd: iamgeresolution checks overflow. #14585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2024
Merged

ext/gd: iamgeresolution checks overflow. #14585

merged 3 commits into from
Jun 16, 2024

Conversation

devnexen
Copy link
Member

also gd updates the resolution only if x/y are > 0.

@devnexen
ext/gd: iamgeresolution checks overflow.
5d21e92 
also gd updates the resolution only if x/y are > 0.
@devnexen devnexen marked this pull request as ready for review June 16, 2024 15:35
Girgias
Girgias reviewed Jun 16, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but I think we should also check that the value is not negative in the first place

@devnexen devnexen merged commit 1fc083e into php:master Jun 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: gd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @Girgias