ext/soap: Continued internal refactoring #14602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Jun 19, 2024
devnexen
reviewed
Jun 19, 2024
| @@ -2114,7 +2118,7 @@ static void add_sdl_to_cache(const char *fn, const char *uri, time_t t, sdlPtr s | |||
| WSDL_CACHE_PUT_N("wsdl", 4, out); | |||
| WSDL_CACHE_PUT_1(WSDL_CACHE_VERSION,out); | |||
| WSDL_CACHE_PUT_1(0,out); | |||
| WSDL_CACHE_PUT_N(&t, sizeof(t), out); | |||
| WSDL_CACHE_PUT_N((char*)&t, sizeof(t), out); | |||
There was a problem hiding this comment.
I like this change: Casting in the WSDL_CACHE_PUT_N macro can hide mistakes. Casting here is more explicit.
|
LGTM apart from the TODO commit |
Move it to the one call site that requires it
Add const qualifiers to the variables at the call size Rename variables when they were shadowing a variable from the outer scope
As serializing something should not affect the value of it
The i seems to be a mistake as everything else uses j
Girgias
force-pushed
the
soap-refactoring2
branch
from
464cae2 to
a4edb5a
Compare
|
Note that adding const to things like encodePtr doesn't make the pointer const. |
Right I was wondering about this, I'll probably do a follow-up when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14579 and commits that have been merged.