Skip to content

Remove support for EOL Apache 2.0 and 2.2 in favor of 2.4+ #14664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 25, 2024

Remove support for EOL Apache 2.0 and 2.2 in favor of 2.4+

Apache 2.2 has been marked as EOL in December 2017 and doesn't receive
security patches any longer. Also, most *nix distributions and packages
mostly support 2.4 as minimum by now.

On Windows, this removes the configure option --enable-apache2-2handler
and merges the --enable-apache2handler and --enable-apache2-4handler
into a single option with favoring the --enable-apache2handler.

  • The upstream MODULE_MAGIC_NUMBER is deprecated in favor of
    MODULE_MAGIC_NUMBER_MAJOR in apache2/ap_mmn.h
  • The initial upstream MODULE_MAGIC_NUMBER_MAJOR was 20111025 in Apache
    2.4.0
  • The upstream APLOG_USE_MODULE is always available since Apache 2.3.6
  • The upstream CORE_PRIVATE is unnecessary and ignored since Apache
    2.4.0

Apache announcement:
https://forum.apachehaus.com/news-general-discussion/apache-2-2-users-your-time-is-running-out/

PHP discussion: https://news-web.php.net/php.internals/124067

@petk petk force-pushed the patch-apache2handler-version branch from 9996dce to 5d7e885 Compare June 29, 2024 22:44
@petk petk force-pushed the patch-apache2handler-version branch from 5d7e885 to 9faa1e8 Compare June 29, 2024 22:46
@petk petk marked this pull request as ready for review June 29, 2024 22:58
@petk petk requested a review from bukka as a code owner June 29, 2024 22:58
@petk petk force-pushed the patch-apache2handler-version branch 2 times, most recently from c9c057a to fe03af4 Compare June 29, 2024 23:03
- The configure options --with-oci8-11g, --with-oci8-12c, --with-oci8-19 have
been removed.
- The configure options --with-oci8-11g, --with-oci8-12c, --with-oci8-19,
--enable-apache2-2handler have been removed.
Copy link
Member

@devnexen devnexen Jun 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be used in the field anymore. Glad with the changes or we can possibly make it an alias too then removing it for 9.x. wdyt ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I was thinking like this. That this --enable-apache2handler option is presumable not used anymore around. And this --enable-apache2-2handler is kind of like targeting specifically 2.2 version. With removing it, it makes the user aware that previous setup won't work anymore, if theoretically someone builds Apache 2.2. Now, there is mainly this --enable-apache2-4handler used, which I've added it like this so it is simpler to migrate and still possibly have (but this is not confirmed at all) Apache 2.6 at some point. Yes, I have no ideal solution here. Perhaps we can add it like an alias also... 🤔

Apache 2.2 has been marked as EOL in December 2017 and doesn't receive
security patches any longer. Also, most *nix distributions and packages
mostly support 2.4 as minimum by now.

On Windows, this removes the configure option --enable-apache2-2handler
and merges the --enable-apache2handler and --enable-apache2-4handler
into a single option with favoring the --enable-apache2handler.

- The upstream MODULE_MAGIC_NUMBER is deprecated in favor of
  MODULE_MAGIC_NUMBER_MAJOR in apache2/ap_mmn.h
- The initial upstream MODULE_MAGIC_NUMBER_MAJOR was 20111025 in Apache
  2.4.0
- The upstream APLOG_USE_MODULE is always available since Apache 2.3.6
- The upstream CORE_PRIVATE is unnecessary and ignored since Apache
  2.4.0

See:
https://forum.apachehaus.com/news-general-discussion/apache-2-2-users-your-time-is-running-out/

Discussion: https://news-web.php.net/php.internals/124067
@petk petk force-pushed the patch-apache2handler-version branch from fe03af4 to 6d63d90 Compare July 6, 2024 12:26
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk
Copy link
Member Author

petk commented Jul 7, 2024

I'll merge this then as it is and we can adjust it in case we run into some unforeseen build issues somewhere. I think this won't cause much issues with 2.0 and 2.2. But hypothetical Apache 2.6 future release might need adjusting code and specially configuration on Windows. At this point I'm not sure how that would be resolved. We can even add a new Windows configure option at that point if that will be needed.

@petk petk merged commit 1bdf9aa into php:master Jul 7, 2024
11 checks passed
@petk petk deleted the patch-apache2handler-version branch July 7, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants