Skip to content

Autotools: Refactor Valgrind support #14736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

Autotools: Refactor Valgrind support #14736

merged 1 commit into from
Jun 30, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 30, 2024

When Valgrind is enabled and not found on the system, default error can be thrown by PKG_CHECK_MODULES instead of writing a manual error step.

  • This uses less redundant variables and has synced CS.
  • AS_VAR_IF used instead of raw shell ifs
  • Added some basic help descriptions for macro definitions

Default error is also more descriptive

configure: error: Package requirements (valgrind) were not met:

Package 'valgrind', required by 'virtual:world', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables VALGRIND_CFLAGS
and VALGRIND_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

@petk
Autotools: Refactor Valgrind support
2c589d4 
When Valgrind is enabled and not found on the system, default error can
be thrown by PKG_CHECK_MODULES instead of writing a manual error step.
- This uses less redundant variables and has synced CS.
- AS_VAR_IF used instead of raw shell ifs
- Added some basic help descriptions for macro definitions
devnexen
devnexen approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@petk petk merged commit 9caad37 into php:master Jun 30, 2024
11 checks passed
@petk petk deleted the patch-valgrind branch June 30, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: pcre
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen