ext/standard: change highlight_string()/print_r stub return type from string|bool to string|true

[Ayesh]

highlight_string either returns string if the $return parameter is true, or always returns true. We can now reflect this in the stubs.

[staabm]

I think these functions use the same kind of construction and might therefore have the same bug:
print_r, var_export, highlight_string, highlight_file, show_source

[Ayesh]

• highlight_file (and its alias show_source) seem to return false if the file is not found.
• var_export has return type ?string. I think it's correctly returning null for var_export(null).

I think you are right about print_r, I will update the PR to include it.

[Ayesh]

Thank you @staabm, print_r now also returns string|true.

[nielsdos]

When changing the stub files you need to rerun ./build/gen_stub.php to update the arginfo files, if that's not updated automatically by doing a make.

[Ayesh]

Thank you, I indeed had forgotten to build arginfo. Fixed now.

[nielsdos]

Right, In this case you also need to pass --generate-optimizer-info to the gen_stub.php command

[Ayesh]

TIL 🙏. Force-pushed with --generate-optimizer-info.

[nielsdos]

LGTM Thanks!