Fix comments after -> operator #14976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
approved these changes
Jul 16, 2024
|
@bwoebi It's quite an unlikely edge case, given it only affects keywords appearing after the comment in this peculiar position. That said, I don't foresee any issues with this PR. |
|
@iluuu1994 I'd agree for a PR of significant complexity, which this one isn't, so yeah. |
|
Okay. I'll merge for 8.2 then ^^ |
Comments should now fall out of ST_LOOKING_FOR_PROPERTY. Fixes phpGH-14961 Closes phpGH-14976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments should now fall out of ST_LOOKING_FOR_PROPERTY.
Fixes GH-14961