Throw error for recursive comparison, instead of fatal #14989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jul 17, 2024
| @@ -0,0 +1,21 @@ | |||
| --TEST-- | |||
| Comparison of a recursive array leads throws a catchable error | |||
There was a problem hiding this comment.
Yeah, double verb sneaked in there. ^^
iluuu1994
force-pushed
the
recursive-comparison-fatal-to-error
branch
from
7b9d97f to
1e0cd19
Compare
I don't understand the rationale of fatal erroring here. It seems this should properly unprotect the compared elements when returning up the stack. Related to phpGH-14980
iluuu1994
force-pushed
the
recursive-comparison-fatal-to-error
branch
from
1e0cd19 to
fc07043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand the rationale of fatal erroring here. It seems this should properly unprotect the compared elements when returning up the stack. If there's another reason I'm missing, please let me know.
Related to GH-14980