Skip to content

Port "gd2: use existing overflow2() rather than ad-hoc version" #15090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 24, 2024

We port this modification[1] from libgd into our bundled libgd, because the change makes sense, and we want the code bases to stay in sync as close as possible.

We also apply a quick fix to the respective test.

[1] libgd/libgd@f0a059b

We port this modification[1] from libgd into our bundled libgd, because
the change makes sense, and we want the code bases to stay in sync as
close as possible.

We also apply a quick fix to the respective test.

[1] <libgd/libgd@f0a059b>
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@cmb69 cmb69 merged commit 6727f54 into php:master Jul 24, 2024
10 of 11 checks passed
@cmb69 cmb69 deleted the cmb/gd2-overflow branch July 24, 2024 12:18
deAtog pushed a commit to deAtog/php-src that referenced this pull request Jul 26, 2024
…15090)

We port this modification[1] from libgd into our bundled libgd, because
the change makes sense, and we want the code bases to stay in sync as
close as possible.

We also apply a quick fix to the respective test.

[1] <libgd/libgd@f0a059b>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants