Skip to content

random: Remove engine_combinedlcg.c #15216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Aug 3, 2024

The standalone engine cannot be usefully used for any other purpose. Remove it and inline the implementation into the php_combined_lcg() function.


Related to #15211

The standalone engine cannot be usefully used for any other purpose. Remove it
and inline the implementation into the `php_combined_lcg()` function.
@TimWolla TimWolla force-pushed the remove-combined-lcg-engine branch from 6d52854 to 7ed6a34 Compare August 3, 2024 16:33
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@TimWolla TimWolla merged commit 6910167 into php:master Aug 4, 2024
10 of 11 checks passed
@TimWolla TimWolla deleted the remove-combined-lcg-engine branch August 4, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants