Skip to content

Reset seen symbols when ending namespace #15244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iluuu1994
Copy link
Member

Previously, seen symbols were never cleaned during the compilation of a single file. This makes it impossible to use a class or function from a different namespace if such a symbol is also declared within the same file. This is inconsistent with how it would work when split into different files.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical to me

iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Aug 13, 2024
Previously, seen symbols were never cleaned during the compilation of a single
file. This makes it impossible to use a class or function from a different
namespace if such a symbol is also declared within the same file. This is
inconsistent with how it would work when split into different files.
@iluuu1994 iluuu1994 force-pushed the reset-seen-symbols-when-ending-namespace branch from dfb1969 to 3d0a6aa Compare August 13, 2024 13:44
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Aug 13, 2024
Previously, seen symbols were never cleaned during the compilation of a single
file. This makes it impossible to use a class or function from a different
namespace if such a symbol is also declared within the same file. This is
inconsistent with how it would work when split into different files.
@iluuu1994 iluuu1994 force-pushed the reset-seen-symbols-when-ending-namespace branch from 3d0a6aa to b93538f Compare August 13, 2024 13:46
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Aug 13, 2024
Previously, seen symbols were never cleaned during the compilation of a single
file. This makes it impossible to use a class or function from a different
namespace if such a symbol is also declared within the same file. This is
inconsistent with how it would work when split into different files.
@iluuu1994 iluuu1994 force-pushed the reset-seen-symbols-when-ending-namespace branch from b93538f to ae2c9cd Compare August 13, 2024 13:46
Previously, seen symbols were never cleaned during the compilation of a single
file. This makes it impossible to use a class or function from a different
namespace if such a symbol is also declared within the same file. This is
inconsistent with how it would work when split into different files.
@iluuu1994 iluuu1994 force-pushed the reset-seen-symbols-when-ending-namespace branch from ae2c9cd to be6dee3 Compare August 13, 2024 13:47
@iluuu1994 iluuu1994 merged commit be6dee3 into php:master Aug 13, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants