Autotools: Remove dependency related errors #15344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ext/dom
- ext/xsl
These use the PHP_ADD_EXTENSION_DEP macro which throws error when one of
the dependencies is disabled or not configured properly.
For example:
./configure --disable-all --enable-dom
or
./configure --disable-all --with-xsl
Will throw default PHP dependency error info, when using
PHP_ADD_EXTENSION_DEP.
These errors were once done when PHP_ADD_EXTENSION_DEP macro wasn't yet
available.
nielsdos
approved these changes
Aug 11, 2024
petk
added a commit
to petk/php-src
that referenced
this pull request
Aug 11, 2024
Follow-up of phpGH-15344 (687eb91) This removes the customized error messages in PDO extensions when PDO is not enabled (--disable-all or --disable-pdo) in favor of the default error done by PHP_ADD_EXTENSION_DEP.
petk
added a commit
to petk/php-src
that referenced
this pull request
Aug 11, 2024
Follow-up of phpGH-15344 (687eb91) This removes the customized error messages in PDO extensions when PDO is not enabled (--disable-all or --disable-pdo) in favor of the default error done by PHP_ADD_EXTENSION_DEP.
petk
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These use the PHP_ADD_EXTENSION_DEP macro which throws error when one of the dependencies is disabled or not configured properly.
For example:
or
Will throw default PHP dependency error info, when using PHP_ADD_EXTENSION_DEP.
These errors were once done when PHP_ADD_EXTENSION_DEP macro wasn't yet available.