Explicitly drop support for old clang versions on Windows #15415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures compatibility with the typedef redefinitions we use, and makes it clear during the
configure
stage that old compiler versions are not supported.See https://releases.llvm.org/ regarding the release history of clang.
Note that clang 3.1.0 added support for C11, and that may include support for typedef redefinitions, but I'm not sure about that. And the oldest clang I've managed to install on my machine is 4.0.0. I did a minimal PHP build successfully, so I'm reasonable sure that the typedef redifinition won't cause an issue as of clang 4.0.0. And frankly, I don't see much point in claiming support for even older clang versions, while clang 4.0.0 has been released on 2017-03-13, and I'm not even sure that newer clang versions are fully supported with PHP on Windows.