Don't skip tests which are supposed to fail; mark them as xfail #15472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially regarding buggy server behavior, we should not skip those tests, because it is unlikely that fixes to the server's behavior will even be noticed. Instead we mark these tests as xfail, so we get a warning if the test succeeds, and can act appropriately.
As well as on some of the CI workflows. That should be investigated; not sure if that test is executed on the other workflows. |
kamil-tekiela
approved these changes
Aug 18, 2024
See How to use mysqli_stmt_attr_get() and mysqli_stmt_attr_set() functions in php? The XFAIL section for this test can be removed. It's a pretty useless test though. The value will always be 1, so it essentially duplicates mysqli_stmt_attr_get.phpt. Maybe we should drop this test. What do you think? |
|
I have a better alternative #15485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially regarding buggy server behavior, we should not skip those tests, because it is unlikely that fixes to the server's behavior will even be noticed. Instead we mark these tests as xfail, so we get a warning if the test succeeds, and can act appropriately.
Note that mysqli_stmt_attr_get_prefetch.phpt passes for me with MySQL 5.6, 8.0 and 9.0.