Autotools: Sync CS in ext/tidy #15561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Aug 23, 2024
petk
commented
- AS_* macros used
- When TIDY_DIR is not set error out in its own "if" sentence
- break 2 used instead of break to exit also the first for loop
- AS_* macros used - When TIDY_DIR is not set error out in its own "if" sentence - break 2 used instead of break to exit also the first for loop
|
Build failure looks legit |
|
Typo fixed in the appended commit. |
|
Yes, this is also a good indicator that migrating to pkg-config and tidy-html5 needs to be probably done in the next PHP version. Here I'll still check in the next days or so if pkg-config can be perhaps optionally added with this tidyp and legacy tidy libraries used like before. Edit: Or actually if these legacy libraries even work at all. |
Good question, CI only tests tidy-html5 AFAIK. |
|
Merge coming up here. Everything looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.