ICU 75.1 requires C++17 #15678
Merged
ICU 75.1 requires C++17 #15678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be explicitly enabled for MSVC (and probably clang on Windows); otherwise the default is C++14, which is no longer sufficient for ICU[1]. While the official PHP 8.4 builds for Windows do not yet use ICU 75.1, that may change[2]. And even if not, it would be nice for custom builds to be able to build against ICU 75.1 (or later). Anyhow, using `std:c++17` is fine for ICU 72.1 which we are currently using (and likely for some older ICU versions). [1] <https://github.com/unicode-org/icu/releases/tag/release-75-1> [2] <https://github.com/winlibs/icu4c/pulls>
What s the minimal MSVC version supported for this branch ? |
Currently there are basically no restrictions (except that vc15 will not compile ext/bcmath). If we merge PR #15403, it would be vs16 (aka. Visual Studio 2019). |
|
ok VS 2019 seems to have full support of C++17. |
Right, but even if it had not, to build ICU 75.1 you need C++17 anyway. |
|
sure I was referring to your conditional/GREP_HEADER sentence. |
devnexen
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be explicitly enabled for MSVC (and probably clang on Windows); otherwise the default is C++14, which is no longer sufficient for ICU[1].
While the official PHP 8.4 builds for Windows do not yet use ICU 75.1, that may change[2]. And even if not, it would be nice for custom builds to be able to build against ICU 75.1 (or later).
Anyhow, using
std:c++17is fine for ICU 72.1 which we are currently using (and likely for some older ICU versions).[1] https://github.com/unicode-org/icu/releases/tag/release-75-1
[2] https://github.com/winlibs/icu4c/pulls
It seems that this is already catered to in ext/intl/config.m4 for other platforms. And maybe it would be better to enable the flag on Windows conditionally, depending on the ICU version (would likely need a
GREP_HEADER()check).