Don't export php_pdo_int.h #15688
Don't export php_pdo_int.h #15688
Conversation
This is, as the name and a comment in the header imply, an internal header which is not supposed to be used by extensions other than PDO (not even by drivers). Since there is apparently no need to include this header in the parsers of the drivers, we remove these includes, and no longer declare the header to be installed. Given that the header is only exported for a couple of weeks[1], this is not considered to be a BC break, because it's unlikely that external drivers have already been adjusted to use this header, and otherwise they can still be fixed; PHP 8.4 is still in the pre-release stage. [1] <php#14797>
There was a problem hiding this comment.
All these related pdo extensions build fine also with phpize. Redundant header indeed. Thanks for catching this. Yes, this is hardly a BC break since this is an internal header. Unless something got missed and something needs it in the parsers. Fine with me anyway.
Regarding php_gmp_int.h; this is exported as of e05cba0. In this case the "int" is likely an abbreviation for "interface", but at least to me that seems to be uncommon for C headers (where "int" usually stands for "internal" to my knowledge), but might be common for C++. The other headers (php_dir_int.h, php_streams_int.h, zend_strtod_int.h) may or may not be meant to be internal headers, and may be exported inadvertently, because we install ext/standard/*.h, main/streams/*.h and Zend/*.h. Might be in order to revisit this for PHP 9; I don't think introducing a BC break for these long-standing issues would be appropriate for a minor PHP version. |
This is, as the name and a comment in the header imply, an internal header which is not supposed to be used by extensions other than PDO (not even by drivers).
Since there is apparently no need to include this header in the parsers of the drivers, we remove these includes, and no longer declare the header to be installed. Given that the header is only exported for a couple of weeks[1], this is not considered to be a BC break, because it's unlikely that external drivers have already been adjusted to use this header, and otherwise they can still be fixed; PHP 8.4 is still in the pre-release stage.
[1] #14797