Remove driver specific support from ODBC #15727
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDO_ODBC doesn't do this, and most of these drivers are not in use with PHP, at least like this. Chances are these expose an ODBC driver you can use with a normal driver manager like unixODBC or iODBC. If not, it can be specified as a custom driver, though it does not include any workarounds. There might be some redundant definitions now as a result. IBM Db2 is kept as a special case due to it also being in PDO_ODBC, though I wonder how good of an idea this is. See phpGH-15630
This would only be used on 68k classic Mac OS. Did PHP ever run there?
All supported driver managers can do extended fetches.
NattyNarwhal
commented
Sep 3, 2024
So we don't need the define?
cmb69
reviewed
Sep 6, 2024
There's no justification behind as to why this should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GH-15630 for motivation and some concerns. Looks like we can get rid of a bunch of ifdefs!
Additional ones I've had since this:
SQL_TIMESTAMPis gated behind Adabas for some reason (inodbc_bindcols), even though it seems general? May need to look into how it gets converted toSQL_C_CHARper ODBC ref.HAVE_SQLDATASOURCESonly gets set on Windows, need to test or assume on Unix