Fix GH-15752: finfo_file() - parameter validation error messages
#15755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the merge to |
Differences between master and release branches is a common occurence, nothing new ! lgtm once you fix the existing tests failures. |
DanielEScherzer
force-pushed
the
finfo_file
branch
from
ad37fc1 to
056cfe7
Compare
DanielEScherzer
changed the title
finfo_file() - parameter validation error messagefinfo_file() - parameter validation error messages
Done - turns out there is an existing test that was just expecting the wrong thing, so I fixed that and dropped my new test |
Show the correct parameter names and numbers - the errors are caused by the second parameter being empty or having null bytes, not the first.
DanielEScherzer
force-pushed
the
finfo_file
branch
from
056cfe7 to
ed32452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the correct parameter names and numbers - the errors are caused by the
second parameter being empty or having null bytes, not the first.